search

veekun / pokedex

more than you ever wanted to know about Pokémon
MIT License
1.44k stars 637 forks source link

CLI commands are always verbose without using flag #298

Closed rluzuriaga closed 4 years ago

rluzuriaga commented 4 years ago

Commands Used:

pokedex dump OR pokedex load OR pokedex setup

Error:

There is no error produced but the commands act as if the verbose flag was added. The command is acting the same when running pokedex dump -v or pokedex dump

Remarks:

I'm not sure if this is supposed to be the case because the parsers are set to default verbose to true. Example code from codebase: cmd_dump.set_defaults(func=command_dump, verbose=True) If verbose is supposed to always be true, then the verbose flag should be removed and the help message should state that. If verbose should not always be true, then the parsers need to be changed.

I am working on pull requests for both cases

rluzuriaga commented 4 years ago

Just realized that there is a quiet flag and that the default is verbose