veekun / pokedex

more than you ever wanted to know about Pokémon
MIT License
1.44k stars 637 forks source link

Fix pokedex dump -l argument error (#295) #299

Open rluzuriaga opened 4 years ago

rluzuriaga commented 4 years ago

pokedex/main.py -

create_parser() -


Resolves: #295

rluzuriaga commented 3 years ago

@magical Any update on this PR? I know it is failing the Travis CI build but that's only because the original dump command was giving the wrong result (which is what this PR fixes) so the git --no-pager diff --exit-code pokedex/data/csv/ script is what is failing.

magical commented 3 years ago

@rluzuriaga Sorry. Thanks for the reminder. I'll take a look.

It seems to be failing because it is dumping the Czech translations where it wasn't before. Hmm. I do still want to test dump -l all but maybe we should follow that with a normal dump so that the diff test works.