Open rluzuriaga opened 4 years ago
@magical Any update on this PR? I know it is failing the Travis CI build but that's only because the original dump command was giving the wrong result (which is what this PR fixes) so the git --no-pager diff --exit-code pokedex/data/csv/
script is what is failing.
@rluzuriaga Sorry. Thanks for the reminder. I'll take a look.
It seems to be failing because it is dumping the Czech translations where it wasn't before. Hmm. I do still want to test dump -l all
but maybe we should follow that with a normal dump so that the diff test works.
pokedex/main.py -
create_parser() -
command_dump() -
Check if 'all' or 'none' codes are passed alongside other codes. If they are, error message is printed and program ends.
pokedex/db/load.py -
dump() -
If 'none' was passed to the parser, then nothing new should be dumped to the csv files.
pokexed/.travis.yml -
Resolves: #295