search

veekun / pokedex

more than you ever wanted to know about Pokémon
MIT License
1.44k stars 637 forks source link

Error in Gen II encounters for Route 31 #313

Open antialiasis opened 3 years ago

antialiasis commented 3 years ago

Somebody bumped into this on TCoD. It looks like the source the Gen II encounter pull request used simply made a mistake here.

If you scroll down that page (Crystal walking encounters) and find Route 31, you'll find it lists Caterpie in the third (20%) slot for morning and day. In reality, this slot has a Bellsprout, as seen in pokecrystal here: https://github.com/pret/pokecrystal/blob/master/data/wild/johto_grass.asm#L1252

For reference, this is the diff for the fix in my fork. https://github.com/antialiasis/pokedex/commit/d655ba6b858f0fdc73c10e10380c5f4e46600ac5

Unfortunately this means the validity of the source's other data is entirely up in the air. I checked a few other random locations and found no other errors, but can't be sure without actually ripping everything to check.

antialiasis commented 3 years ago

(Incidentally it does seem like pokegold has wild encounters now, so it should be possible to get them from there...)

magical commented 3 years ago

cc @Rogerooo

Yep, definitely need to do a re-rip now that pokegold has encounter data (thanks for pointing that out!)

magical commented 3 years ago

Looks like there are a bunch of issues with GSC encounters: #315. I think maybe we should revert them until a proper rip can be done. What do you think?