veekun / pokedex

more than you ever wanted to know about Pokémon
MIT License
1.44k stars 637 forks source link

Different genus according to the form #317

Open edcrfv0 opened 3 years ago

edcrfv0 commented 3 years ago

In a few cases, genus can be different between the forms: Mr. Mime: Barrier Pokémon Galarian Mr. Mime: Dancing Pokémon

Darmanitan: Blazing Pokémon Galarian Darmanitan: Zen Charm Pokémon

Hoopa Confined: Mischief Pokémon Hoopa Unbound: Djinn Pokémon

itsjavi commented 2 years ago

This seems a limitation of the DB schema

IMHO all species and forms should share the same data structure, with forms having just a flag to differentiate them from species: e.g. is_form = true/false and form_base=pokemon_id. Maybe a nullable form_base is even enough: if it's null, then it's an species.