Add Let's Go Pikachu/Eevee and Sword/Shield data

[Parnassius]

Closes #311 Closes #284 Closes #262 Closes #210 Closes #231

[magical]

Oh, one thing i missed from Let's Go - it looks like the partner forms of Pikachu and Eevee are missing. They probably got lost when you dropped unobtainable pokemon from the rip.

[magical]

BTW, it looks like you mostly chose the same form identifiers as i did for the HOME sprites (https://github.com/veekun/pokedex/commit/b09929dfb636d2b0337edbfe6761496c7d435965).

I think the only differences are:

• darmanitan-galar-standard vs darmanitan-standard-galar
• darmanitan-galar-zen vs darmanitan-zen-galar
• zacian-crowned vs zacian-crowned-sword
• zamazenta-crowned vs zamazenta-crowned-shield
• pikachu-starter vs pikachu-partner
• eevee-starter vs eevee-partner

That's fine, we don't have to resolve those right now. Just thought it was worth noting.

Also, note to self: i'll need to copy a few sprites to accommodate the new zygarde forms.

[Parnassius]

Oh, one thing i missed from Let's Go - it looks like the partner forms of Pikachu and Eevee are missing. They probably got lost when you dropped unobtainable pokemon from the rip.

Whoops, you're right, i dropped them when i removed the unobtainable pokemon, along with megas and alolan forms (those are mainly relevant for pokemon_moves.csv)

Edit: I addressed your comments as separate commits to ease the review, i'll squash them together when this is ready to be merged

[Parnassius]

I just noticed there were 4 more items with duplicate identifiers, i just fixed them.

• pokemon-box (from let's go, row 1007) was renamed to pokemon-box-link in sword/shield, even though the "real" pokemon-box-link is row 1139. I reverted the identifier to the old one
• leaf-letters are now called leaf-letter--pikachu and leaf-letter--eevee
• fishing-rod from sword/shield is now called fishing-rod--galar. The other one still refers to Lana from sun/moon in its description, so i would keep them separate
• reins-of-unity, i used the same --merge and --split suffixes already used for kyurem's and necrozma's items. In this case there's an additional third item (row 1658), which i left as-is. According to the description it seems to be the item you get in the dlc before you catch calyrex; when it's caught i think it becomes reins-of-unity--split, and after that upon splitting/fusing it switches between that one and reins-of-unity--merge, as expected

[magical]

Looking good, thanks.

I tried loading the data into PostgreSQL and ran into a couple problems:

1. items.category_id is required
2. pokemon.shape_id can't be 0

Shapes: i'd be fine just marking this nullable for now. I know shapes still exist, at least in HOME, and we'll definitely want to rip them at some point, but there's no reason we have to do it right now.

Looks like was wrong about item categories, oops. It's true that categories are non-official and we don't strictly need them, but we do need to know the item pocket, and pockets are linked to categories. Pockets are semi-official: the current ones are from the D/P/Pt days and correspond roughly to the pockets in the bag from that game, although obviously lots of other games have come out since then that had slightly different pocket schemes. You can make a "sw/sh uncatagorized" category in one of the pockets and throw all the items in there for now. (If you want to try ripping them though, i think the pockets roughly correspond to this field in the item data.)

---

A couple other things i noticed:

• TM25 is listed as Max Guard, but Bulbapedia says it is Protect. Is that right?
• Xerneas has no default form. xerneas-neutral should be the default.

[Parnassius]

* TM25 is listed as Max Guard, but Bulbapedia says it is Protect. Is that right?

Whoops, fixed. I compared the list with both Bulbapedia's and Serebii's, and now everything seems to be ok

* Xerneas has no default form. `xerneas-neutral` should be the default.

I'm dumb, fixed

Shapes: i'd be fine just marking this nullable for now. I know shapes still exist, at least in HOME, and we'll definitely want to rip them at some point, but there's no reason we have to do it right now.

The search filter is indeed missing in Sword and Shield's pokedex, I'm honestly not sure if the data is still available somewhere in the game files. Should I simply set nullable=True in this line, or there's something more involved to do?

Looks like was wrong about item categories, oops. It's true that categories are non-official and we don't strictly need them, but we do need to know the item pocket, and pockets are linked to categories. Pockets are semi-official: the current ones are from the D/P/Pt days and correspond roughly to the pockets in the bag from that game, although obviously lots of other games have come out since then that had slightly different pocket schemes. You can make a "sw/sh uncatagorized" category in one of the pockets and throw all the items in there for now. (If you want to try ripping them though, i think the pockets roughly correspond to this field in the item data.)

I had a couple of problems trying to rip them, since as you said the pockets are from D/P/Pt. These are the main things I'm unsure about:

• the let's go main menu buttons (pokemon-box/medicine-pocket/candy-jar/etc): I put them in key => unused, even though they are not properly key items
• the various things eevee and pikachu can pick up in let's go: I put them in misc => loot, I don't think there's anything better?

I also created a couple new categories:

• misc => species-candies
• berries => catching-bonus (golden/silver razz/nanab/pinap berries)
• misc => dynamax-crystals
• medicine => nature-mints
• misc => curry-ingredients

Everything else seemed to be pretty straightforward

(I squashed almost everything together because I can't git apparently, if for any reason you need to check the individual commits they're still available here)

[magical]

Thanks. I'll take another look in case i missed something, but i want to try and get this merged this weekend.

The search filter is indeed missing in Sword and Shield's pokedex, I'm honestly not sure if the data is still available somewhere in the game files. Should I simply set nullable=True in this line, or there's something more involved to do?

np, I'll take care of it.

[magical]

Merged. Thank you!