Open magical opened 3 years ago
Using this patch the tests pass with sqlalchemy 1.4, while maintaining compatibility with 1.0-1.3. Unfortunatly the Query._execute_and_instances
method doesn't seem to be subclassable anymore, and the docs suggest using do_orm_execute
instead.
The warnings are still there, but silencing them with viewonly=True
should be safe to do (the data is never modified outside of the setup/load/dump functions, is that correct?)
Attempting to run
pokedex setup
when using SQLAlchemy 1.4 throws an error and spews a bunch of warnings.Here's the relevant portion of the Travis CI log: