search

veelenga / aws-lambda-face-blur

AWS Lambda Face Blur
18 stars 3 forks source link

[FEATURE] Skip gm altogether if there are no faces deteced #1

Open afoeder opened 4 years ago

afoeder commented 4 years ago

Hi @veelenga,

thanks for your inspirational code that got me kickstarted to implement my own face detection and blurring.

While adapting, I realized that you could directly copy the "untouched" buffer to the final s3 bucket without directing it through GM, if there are no faces detected anyways.

Just wanted to suggest this.

veelenga commented 4 years ago

Hey @afoeder. Thanks for the interest. Could you please explain why would you like to do this? Yes, it can be done, however will lead to a slight refactoring since it will break the implemented waterfall model

afoeder commented 4 years ago

it's just because; why would you light up Image Magick if it has nothing to do altogether; it would lead to additional "cost" in terms of processing, and most likely to image quality loss since it's piped through GM/IM unecessarily. Do you get what I try to say? :)

veelenga commented 4 years ago

Ok, this makes sense. Will rework this once i have some time