Update icon usage within maker table

[TangerineFloof]

Description

This PR updates how we use and display icons within the maker table.

Before:

After:

The overall goal with this PR was to remove the Legend modal. Within UI and web design, needing a Legend for something is generally an anti-pattern. It means that meaning is located separately from where it's consumed, requiring users to be confused about what something means and cross-reference it in another location. Legends can be removed by improving iconography, annotating information inline, through reinforcement learning, and other factors.

Notable Changes:

• Icons are skimmable. Icons are consistently found in the same horizontal location.
• Removed Legend. Removed the Legend modal.
• Styling touchup. I've added color coordination and a bit of styling.

Regarding the age icons:

• I've consolidated both "all makers at studio are < 18" and "mixture of under and over 18" into the minors tag
• I've removed the "unknown age" icon

The reason for these changes is simple: icons demand attention. If we put an icon there, your eye will be drawn to it. We also need to consider what goal we're trying to solve for here: how will the user make use of this info, and what question of theirs does it solve? In the case of "unknown age," I don't think we're doing anything for the user there. We're saying "we don't have any data" which isn't actionable, and isn't noteworthy.

In Telegram, we discussed hedging our bets. The idea was that our data was incomplete so "unknown" could represent a minor. I think this could be true, but I don't think this should be enough reason to bring this to the user's attention (at least, not on this page):

• This table is meant to be a summary — the user is supposed to click from here onto their profile page, where we can provide more detail (including "hi we don't know the maker's age, please don't send NSFW requests until you've confirmed their age first")
• The user can't really do anything with this info (specifically, "we don't know the maker's age" isn't immediately actionable to the user in the same way "this maker is a minor" is)
• I'm not convinced that this ("is the maker's age definitively known") is among the most fundamentally important user concerns here (versus other questions like "are they open for commissions" or "will they open for comms soon?" etc)
• getfursu.it shouldn't be expected to be an authority on all data — we absolutely have duty of care to represent makers as best and accurately as possible, and be correct in our info. However, we're never going to be as accurate as the maker's own websites, and I think we should think about the product more as "this is a first stop to get data on makers, but users will continue on to maker's websites from here before reaching out to the makers."
• We should start trusting our data more, and also requiring it be accurate. If makers want the "minor" badge in order to advocate for themselves that they're < 18, then they need to explicitly tell us that they're minors. If a maker's listing on getfursu.it isn't 100% accurate, I don't know that this is really our obligation to address vs. the maker's. If a maker's data doesn't have age and they want to list that they're < 18, fantastic! I think they should reach out and have us update it. I don't know that, in absence of this, that we need to lose any sleep over it. I think living in fear of the perceived holes in our data will only make it harder for us to work with the data long-term.

I'm writing out my thoughts here because this was a longer conversation in Telegram already and I wanted to present my thoughts altogether.

[veelkoov]

Mix of facts and opinions in radom order:

• unknown is also a way to indicate lower quality of (older) data. I believe users may prefer to first focus on the best information before resorting to digging through the leftovers.
  • It often lacks the possibility to filter/set order.
  • Remember that a user seeing unknown is warned "this COULD be the one you do NOT want, you can first check the other ones before committing the time to check this one"
  • This screams for sorting option
• IS_MINOR (later replaced by AGES https://github.com/veelkoov/fuzzrake/issues/103 ) was introduced as a mandatory field in September 2021. If someone "unknown" was still a minor right now, they would have to be <= 15 y.o. when they were submitting data.
  • You cannot "sign up", nor update without stating your age now.
  • This could be seen as an argument to excuse treating unknown as ADULTS
• The table has links allowing to navigate to makers' webpages without opening the card. Back when statistics/tracker was deployed on the website, the stats shown bigger interests in those links than the links on the card. This could indicate that users preferred "just take me to their website, I don't want to open the card" or the users who opened the card were more likely to skip opening the websites after reading the card (faster rejection).
  • We may need to make "the user is supposed to click from here onto their profile page" a rule and remove the links from the table
  • Some users could be dissatisfied with this change
  • On the other hand, who comes to getfursu.it on a regular basis after they get what they want?

• getfursu.it shouldn't be expected to be an authority on all data — we absolutely have duty of care to represent makers as best and accurately as possible, and be correct in our info. However, we're never going to be as accurate as the maker's own websites, and I think we should think about the product more as "this is a first stop to get data on makers, but users will continue on to maker's websites from here before reaching out to the makers."

  • Agree 100%.
  • What I hate on price comparison pages is the fact that you cannot easily mark mis-categorized items, or ignore them in future searches.

Let me now checkout this and test.

[veelkoov]

• I introduced AGES field (enum) with the MIXED age option after it turned out that one maker couldn't state the truth about their studio in the IS_MINOR (boolean) field within a few weeks after introducing the change. :) Requirements gathering fail, but don't we love such events?
• Purposes of the whole age tracking are:
  • Fursuit makers may not want to commission a minor. But they should not be bothered much if a minor works with an adult. So: let's make the "Minor" icon represent MINOR only, but not MIXED.
  • I will need to solve #103 first so that you don't need to care about the legacy field, and this will also improve the name of the method magically ;)
  • As long as there is a single minor in the studio, Fuzzrake will not allow advertising NSFW by that studio, period. This is now the primary purpose of the MIXED age option. Nothing will change here, and it's also all backend for now, so you don't need to worry about this.

I will try to resolve #103 ASAP and then ask you for merge from develop.

Another issue I have is the "new" icon. I deliberately used the "recently added" label, because it makes a difference. Studios are not required to join getfursu.it. Big studios could not care at all, they are big. It's actually a favor if they join, because they are improving getfursu.it and get nothing from it. To sum up: the icon represents newly added studios, but not new studios. Thus, we need to think if it is OK to label them as "new". Obviously, they are big, so no harm done if for 6 weeks they will receive less attention, but... doesn't this deserve some kind of explanation? Or is there a way of labelling it better? Tiny issue I can ignore if you don't see this as important.

After figuring out the above, I will proceed with code rev. For now: please

./toolbox pcf
./toolbox tcf

[veelkoov]

* I will need to solve [Remove IS_MINOR #103](https://github.com/veelkoov/fuzzrake/issues/103) first so that you don't need to care about the legacy field, and this will also improve the name of the method magically ;)

Done https://github.com/veelkoov/fuzzrake/pull/245. Edit: although I was surprised the field was not referenced already. I must have forgotten about removing its use already.