search

veepee-oss / Vp.FSharp.Sql

Generic F# ADO Provider Wrapper
https://github.com/veepee-oss/Vp.FSharp.Sql
ISC License
35 stars 3 forks source link

fix MARS workflow issue when there is an empty result set inside #28

Closed ReynBer closed 2 years ago

ReynBer commented 2 years ago

To fix the behaviour on a multiple result set workflow when there is one or more empty result set inside (not the first one). Currently, as soon as the empty result set is reached, it stops the reading and we have a partial result.

akhansari commented 2 years ago

Hi Reynald ^^

The dotnet version is in Directory.Build.props file, so as not to change all projects.

natalie-o-perret commented 2 years ago

Hi @ReynBer, just finally catching up with the MR like what we discussed the other day, now that I have been discharged from the hospital, and so far, from what I've skimmed through, this lgtm 👍.

[EDIT] thanks a lot btw (didn't wanna sound ungrateful)

Though, I need to conduct some additional tests (I've spotted something a lil' weird, continuation-wise, just wanna make sure we don't have another type of regression). I have some errands to attend today and I might also need to add an extra change.

I will rebase and merge tonight after the nurse is done changing the bandages, will push a release between tonight and tomorrow evening.

Just one wee tiny bit of nitpicking here, imo, this is not only a MARS issue but a more global continuation problem when fetching the rows (and when the reader is actually stopping), the title can be a tad misleading as MARS echoes a bit too much with SQL Server, but this could happen with any other type of provider that would behave similarly under some circumstances.

Note: @akhansari thanks for the review.