search

veepee-oss / Vp.FSharp.Sql

Generic F# ADO Provider Wrapper
https://github.com/veepee-oss/Vp.FSharp.Sql
ISC License
35 stars 3 forks source link

feat(deps): add deps design #3

Closed natalie-o-perret closed 3 years ago

natalie-o-perret commented 3 years ago

Add support for logging capabilities (wip) Redesign with deps design to avoid cluttering with functions

natalie-o-perret commented 3 years ago

Can add the unit tests required for testing that logging callbacks are actually called when they are expected to be called (might need to change the CI), see object expressions.

natalie-o-perret commented 3 years ago

Typo SqlCommand shoud.fs => SqlCommand should.fs

Instead of incrementing the variable manually, you can leverage the incr function, just as in:

[<EntryPoint>]
let main _ =
    let i = ref 0
    incr i
    printfn "Granted, that this is not the best use case ever: %A" i.Value
    0
natalie-o-perret commented 3 years ago

Tests for transactions + pbt will be apart of another issue ticket

natalie-o-perret commented 3 years ago

int => int32 : sake of clarity