search

veeresht / CommPy

Digital Communication with Python
http://veeresht.github.com/CommPy
BSD 3-Clause "New" or "Revised" License
538 stars 176 forks source link

no __version__ argument #104

Closed londumas closed 3 years ago

londumas commented 3 years ago

There does not seem to be a version argument for the package.

import commpy

commpy.__version__
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-2-68df451740b3> in <module>
----> 1 commpy.__version__

AttributeError: module 'commpy' has no attribute '__version__'
python -m pip show scikit-commpy
Name: scikit-commpy
Version: 0.7.0
BastienTr commented 3 years ago

Your right, there is no such argument. I'm not familiar with the convention. Is the version argument a PEP-recommended thing?

BastienTr commented 3 years ago

Hi @londumas,

I just checked and the PEP396 seems to promote the following solution rather than the uses of __version__. 

from importlib.metadata import version
version('scikit-commpy')