veeresht / CommPy

Digital Communication with Python
http://veeresht.github.com/CommPy
BSD 3-Clause "New" or "Revised" License
551 stars 179 forks source link

Fixed installation error on Chinese version of Windows 10 #113

Closed songlei-cn closed 2 years ago

songlei-cn commented 2 years ago

When I installed CommPy on Chinese version of Windows 10, I came across an error: " File "C:\Users\songlei-cn\AppData\Local\Temp\pip-install-77v4aupp\scikit-commpy_e4831557bdbb40d5b50ec608ac738943\setup.py", line 9, in LONG_DESCRIPTION = open('README.md').read() UnicodeDecodeError: 'gbk' codec can't decode byte 0x9d in position 5282: illegal multibyte sequence". It seems that the default encoding for Chinese version of Windows 10 is 'gbk' instead of 'utf-8'. It is necessary to explicitly declare the open function using UTF-8 encoding.

BastienTr commented 2 years ago

Merged in #117