search

veeresht / CommPy

Digital Communication with Python
http://veeresht.github.com/CommPy
BSD 3-Clause "New" or "Revised" License
538 stars 176 forks source link

Quick fix in setup.py #117

Closed edsonportosilva closed 1 year ago

edsonportosilva commented 1 year ago

Hi guys, there is an issue preventing the installation of CommPy 0.7.0 via PIP in Windows. When attempting to do pip install scikit-commpy on Windows, version 0.6.0 is installed instead, due to a bug in setup.py in version 0.7.0. I don't know if the same issue appears in other OS. Looking at the error logs and similar issues reported on StackOverflow, I found a quick fix.

In setup.py, change:

LONG_DESCRIPTION = open('README.md').read()

to

LONG_DESCRIPTION = open('README.md', encoding="utf8").read()

That should fix the pip installation on Windows. I tested it and this fix allowed me to install version 0.7.0 on my Windows PC.

BastienTr commented 1 year ago

Thanks :+1: