veeresht / CommPy

Digital Communication with Python
http://veeresht.github.com/CommPy
BSD 3-Clause "New" or "Revised" License
551 stars 179 forks source link

Remove slow flag in Travis configuration file #77

Closed BastienTr closed 4 years ago

BastienTr commented 4 years ago

The flag -a 'slow' in the Travis configuration file creates two issues:

Removing this flag would leads to a much longer computation time on Travis. I'm not aware of any limitation from Travis on the amount of computation that can be executed. Moreover, imo it is safer to have a reliable test that take a long time to execute rather than an inconsistant short one.

If the computation time is really an issue, we could split the tests in two command lines. The first command execute only the short tests and provides a quick answer then the other tests are run afterwards. If you prefer this option, feel free to push on my branch or to merge the PR and do the changes.

BastienTr commented 4 years ago

The Travis error come from the bug discussed in #76. The logs proves that removing the flag is a solution to detect such bugs.

veeresht commented 4 years ago

Thanks @BastienTr. I seem to have forgotten why I put that flag in earlier, but removing it seems like an obviously right thing to do now :smile: