Fix issue #76 - Githubissues

veeresht / CommPy

Digital Communication with Python

http://veeresht.github.com/CommPy

BSD 3-Clause "New" or "Revised" License

538 stars 176 forks source link

Fix issue #76 #78

Closed eSoares closed 3 years ago

eSoares commented 3 years ago

Unwrapping from tuple back to np.array to be able to call .astype

eSoares commented 3 years ago

Just re-run the tests on my machine and everything passes... Run particular test that failed (commpy.channelcoding.tests.test_convcode.TestConvCode.test_conv_encode_viterbi_decode) five times, a couple of the times failed (1 and 3 mismatched elements). Maybe is the randomness that once in a while, causes the failure?

I know that with the explicit seed, randomness should be controlled and not fail, but the experience indicates otherwise...

BastienTr commented 3 years ago

You're right. The seed() instructions were not called accordingly. I moved them into each tests and the results looks consistant now. I'll merge the PR as soon as Travis confirms it.