Fix README code example for channelcoding

veeresht / CommPy

Digital Communication with Python

http://veeresht.github.com/CommPy

BSD 3-Clause "New" or "Revised" License

551 stars 179 forks source link

Fix README code example for channelcoding #92

Closed londumas closed 3 years ago

londumas commented 3 years ago

Fix both issues : https://github.com/veeresht/CommPy/issues/90 and https://github.com/veeresht/CommPy/issues/89.

This PR fixes different issues with the example code in channelcoding/README.md :

memory should be a numpy 1D array
np.array([[0o171, 0o133]]) generator matrix was producing errors, I replaced by the one in the docstring examples np.array([[5, 7]])
decoded messages and demodulated messages can be padded due to the modulation type.

coveralls commented 3 years ago

Coverage remained the same at 82.353% when pulling 1fc1334a0561a273a4e26d11069f81afed643212 on londumas:fix-codding-deconding-readme into 65bfc19ac0f31adde87ce273eaaf84031c357d23 on veeresht:master.