Open mpaparna opened 3 years ago
did you find the issue in the library itself or what ?
There is something that looks strange in the puncturing code in the current revision:
In https://github.com/veeresht/CommPy/blob/master/commpy/channelcoding/convcode.py#L500 we define a default value for the puncturing matrix, so from this point the matrix should not be None
. But later, in https://github.com/veeresht/CommPy/blob/9aecd7c598e1b3b868fd9d8a1d04e207b39487ad/commpy/channelcoding/convcode.py#L523 , we do not apply the puncturing matrix if the matrix actually defined. It looks to me that the puncturing is never applied on the size of p_outbits
and we are stuck with the default 1/2.
Hi, I am trying to execute the readme.md example for convolutional coding at code rate 3/4. The generator matrix [5, 7] for R=1/2 is used and punctured with [[1,0,1],[1,1,0]] to get R=3/4. But the BER values of viterbi decoded outputs are higher than that of uncoded output. Also the size of the coded bits is as per 1/2 rate and not 3/4. Is it an issue with the 'conv_encode' function or am I missing any steps in between?
Also is there any method to get the coding rate 3/4 using generator matrix?
PS: The package and libraries are from the Github cloned version.