veeso / suppaftp

a super FTP/FTPS client library for Rust with support for both passive and active mode
Apache License 2.0
121 stars 31 forks source link

fix Async SSL file uploads not properly closing #78

Closed mousetail closed 6 months ago

mousetail commented 7 months ago

ISSUE NUMBER - PULL_REQUEST_TITLE

Fixes #77

Description

Current code relies on drop() to close connections. This seems to not be enough for the SSL connection (perhaps because the close itself also blocks).

An explicit call to .close() seems to fix the issue.

List here your changes

Type of change

Please select relevant options.

Checklist

Acceptance tests

wait for a project maintainer to fulfill this section...

mousetail commented 7 months ago

The clippy errors seem unrelated to the changes