search

veeso / termscp

🖥 A feature rich terminal UI file transfer and explorer with support for SCP/SFTP/FTP/S3/SMB
https://termscp.veeso.dev
MIT License
1.66k stars 48 forks source link

[Feature Request] - Make SAMBA share optional #196

Open ogarcia opened 1 year ago

ogarcia commented 1 year ago

Description

Right now you need to enter the SAMBA share to be able to connect to the remote, it would be interesting to make this optional and to list the shares in case you are not provided with any.

Changes

Make the share field of the form optional and in that case list the remote shares.

0323pin commented 1 year ago

Actually, I would prefer if the whole smb module could be feature gated, https://github.com/veeso/pavao/issues/5#issuecomment-1597404025

veeso commented 1 year ago

It doesn't look like libsmbclient has a function to list shares, or I cannot find it 🤷🏻

ogarcia commented 1 year ago

It doesn't look like libsmbclient has a function to list shares, or I cannot find it 🤷🏻

I don't understand much about C, but this is the function that lists the shares in smbclient: https://github.com/samba-team/samba/blob/master/source4/client/client.c#L2684

Maybe with that information something can be done.

veeso commented 1 year ago

Oook, it looks like it's only in SMB4. It could be a future development, but I'd need to think about how to display on the UI, it may be not that easy to handle tbh

veeso commented 1 day ago

It's been a long time, but this probably requires something similar to what has been done with the MultiPodFs for Kube. Not a quick task, but at least plannable for 0.17