[BUG] - SMB Isn't Scoped in the Code

[TheBrenny]

Description

The logs below show that Smb-related types aren't in scope. I'm going to guess this is wrong because there are clearly working builds?

Steps to reproduce

Both default and --no-default-features don't work.

Expected behaviour

Termscp should install correctly from Cargo.

Environment

• OS: Windows 11 22H2 (22621.1848)
• Architecture x86_64
• Rust version: rustc 1.70.0 (90c541806 2023-05-31)
• termscp version: 0.12.1

Log

$ cargo install --locked --no-default-features termscp
[...]
error[E0412]: cannot find type `SmbParams` in this scope
   --> C:\Users\TheBrenny\.cargo\registry\src\index.crates.io-6f17d22bba15001f\termscp-0.12.1\src\filetransfer\builder.rs:144:27
    |
144 |     fn smb_client(params: SmbParams) -> SmbFs {
    |                           ^^^^^^^^^ not found in this scope
    |
help: consider importing one of these items
    |
5   + use crate::config::bookmarks::SmbParams;
    |
5   + use crate::filetransfer::params::SmbParams;
    |

error[E0412]: cannot find type `SmbFs` in this scope
   --> C:\Users\TheBrenny\.cargo\registry\src\index.crates.io-6f17d22bba15001f\termscp-0.12.1\src\filetransfer\builder.rs:144:41
    |
144 |     fn smb_client(params: SmbParams) -> SmbFs {
    |                                         ^^^^^ not found in this scope

error[E0433]: failed to resolve: use of undeclared type `SmbParams`
   --> C:\Users\TheBrenny\.cargo\registry\src\index.crates.io-6f17d22bba15001f\termscp-0.12.1\src\utils\parser.rs:316:37
    |
316 |                 ProtocolParams::Smb(SmbParams::new(address, share).username(username)),
    |                                     ^^^^^^^^^ use of undeclared type `SmbParams`
    |
help: consider importing one of these items
    |
6   + use crate::config::bookmarks::SmbParams;
    |
6   + use crate::filetransfer::params::SmbParams;
    |

error[E0433]: failed to resolve: use of undeclared type `SmbCredentials`
   --> C:\Users\TheBrenny\.cargo\registry\src\index.crates.io-6f17d22bba15001f\termscp-0.12.1\src\filetransfer\builder.rs:145:31
    |
145 |         let mut credentials = SmbCredentials::new(params.address, params.share);
    |                               ^^^^^^^^^^^^^^ use of undeclared type `SmbCredentials`

error[E0433]: failed to resolve: use of undeclared type `SmbFs`
   --> C:\Users\TheBrenny\.cargo\registry\src\index.crates.io-6f17d22bba15001f\termscp-0.12.1\src\filetransfer\builder.rs:154:9
    |
154 |         SmbFs::new(credentials)
    |         ^^^^^ use of undeclared type `SmbFs`

Some errors have detailed explanations: E0412, E0433.
For more information about an error, try `rustc --explain E0412`.
error: could not compile `termscp` (bin "termscp") due to 5 previous errors
error: failed to compile `termscp v0.12.1`, intermediate artifacts can be found at `C:\Users\THEBRE~1\AppData\Local\Temp\cargo-installrtJ2KG`

[veeso]

While this is actually an issue and it needs to be fixed, there's actually no point in disabling smb on Windows, since it is natively supported.

[TheBrenny]

I'm curious to know why it's not building correctly though, if SMB is native on Windows. Like is there a crate that's just not doing it's job right or something?

[github-actions[bot]]

This issue is stale because it has been open for 30 days with no activity.

[veeso]

fix merged into develop branch