search

veeso / termscp

🖥 A feature rich terminal UI file transfer and explorer with support for SCP/SFTP/FTP/S3/SMB
https://termscp.veeso.dev
MIT License
1.65k stars 48 forks source link

[BUG] SFTP cannot handle username with @ symbol #257

Closed slapcat closed 2 months ago

slapcat commented 3 months ago

Description

My username is an email address with an @ symbol and nearly all functionality with SFTP breaks with that (adding SSH key, removing key, connecting with key). The same server works fine with a username without an @.

Steps to reproduce

This issue affects multiple components of termscp:

  1. Add SSH key with hostname server.com and user john.doe@example.com.
  2. Try to delete that SSH key. It will ask to confirm the deletion then doing nothing. Logs show it tries to remove example.com@john.doe. The UI shows the key listed as john.doe at example.com.
  3. Try to connect to server.com via SFTP with the SSH key. It will not find the SSH key and say it failed due to bad username/password.

Expected behaviour

The program can parse a username with an @ in it and not assume the first term after the @ is the host.

Environment

github-actions[bot] commented 2 months ago

This issue is stale because it has been open for 30 days with no activity.

slapcat commented 2 months ago

This is still an issue. @veeso is this something you could fix?

veeso commented 2 months ago

Yes, absolutely. I've planned to make a new release within the next two weeks finally.

veeso commented 2 months ago

Merged into develop. Will be released soon in 0.14