veevelder / quick-combat

FoundryVTT module for small Combat Enhancements
MIT License
6 stars 5 forks source link

[ISSUE] Previous playlist does not resume playing after combat #22

Closed rikmarais closed 1 year ago

rikmarais commented 2 years ago

Describe the bug Previous playlist does not resume playing after combat ends if Fanfare playlist is set to None. If Fanfare is set to an existing playlist with a track in it, then the previous playlist does resume playing.

To Reproduce Steps to reproduce the behavior:

  1. Configure Combat Playlist, and None for Fanfare Playlist
  2. Make sure a playlist is playing.
  3. Begin combat
  4. End combat
  5. Does not return to the playlist that was playing in step 2.

If Fanfare Playlist is configured in step 1, then step 5 does return to the previous playlist.

Expected behavior Should return to playlist in step 2 regardless of whether a Fanfare is set.

Screenshots image image ^ Does not return to previous playlist, and no Fanfare plays

image ^ Does return to previous playlist after Fanfare plays

Version Information

Additional context

Foundry Virtual Tabletop: Version 10, 10.290
Game System: dnd5e, 2.0.3
Active Modules: 1
Performance Mode: 2

OS: Unknown
Client: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) FoundryVirtualTabletop/10.290.0 Chrome/104.0.5112.102 Electron/20.1.0 Safari/537.36
GPU: ANGLE (NVIDIA, NVIDIA GeForce RTX 3060 Laptop GPU Direct3D11 vs_5_0 ps_5_0, D3D11)
Max Texture Size: 16384

Scene: 6000 x 4600 | Grid Size: 100 | Padding Percentage: 0.25
Walls: 0 | Ambient Lights: 0 | Ambient Sounds: 0 | Tiles: 0 | Tokens: 1

Actors: 1 | Items: 0 | Journal: 0 | Rollable Tables: 0 |
Playlists: 5 | Compendium Packs: 14 | Chat Messages: 5
ThingsCouldGetDicey commented 2 years ago

to add to this i believe the conflict is caused when a audio needed by a scene i.e if its initial playlist or ambient audio/ has macro links to audio. it will not revert back to the previous playlist whilst using the forge. but when using a client it is fine.

veevelder commented 2 years ago

I can't seem to replicate your issue, can you provide screenshots/console log (hit F12 and go to the console tab), also try updating to the newest version I made some modifications on how the playlists are starting and it may fix your issue.

ThingsCouldGetDicey commented 2 years ago

i will test now

ThingsCouldGetDicey commented 2 years ago

image i tested on firefox and it doesnt come back to the original playlist after the update

ThingsCouldGetDicey commented 2 years ago

image my result on chrome.

veevelder commented 2 years ago

I think I figure out what was going on, looking at your logs it was attempting to start a playlist with no name/id I've added some checks to make sure that those exist and error if not. Can you check again, in addition can you add the debug messages to the logs? (if it still doesnt work)

image

make sure the verbose is checked

ThingsCouldGetDicey commented 2 years ago

image

ThingsCouldGetDicey commented 2 years ago

after update still getting repeated messages and not resuming image

ThingsCouldGetDicey commented 2 years ago

is it possible i could show you whats happening via discord?

veevelder commented 2 years ago

sure thing, sent a request on discord

veevelder commented 2 years ago

this issue should be fixed in the newest release, update and let me know if its working for you.

ThingsCouldGetDicey commented 2 years ago

it works! well done! thank you! the resume works too!