search

veevelder / quick-combat

FoundryVTT module for small Combat Enhancements
MIT License
5 stars 5 forks source link

[ISSUE] Enable combat markers not displaying #28

Closed tehguitarist closed 1 year ago

tehguitarist commented 1 year ago

Describe the bug I have sequencer and JB2A Animations (Patreon version) installed and I'm not seeing the option for enabling combat markers. It may be because I have the patreon version of the JB2A module? Not a huge deal, I just like the on deck option that other modules don't have. Having a look i'd say it's this line (249 in quick-combat.js) config: (game.modules.get("JB2A_DnD5e")?.active ?? false) && (game.modules.get("sequencer")?.active ?? false),

I think the patreon id is: jb2a_patreon

To Reproduce Steps to reproduce the behavior: Open quick combat settings

Expected behavior The combat marker setting to be available.

Version Information

veevelder commented 1 year ago

thanks for the report and yeah that would be exactly why you are not seeing the setting. Since I don't have the paid version of the JB2A module can you tell me its name? if you open the console menu (F12) in a running game and type game.modules and let me know the JB2A... (Patreon) name should be I can fix that

tehguitarist commented 1 year ago

No problems at all!

jb2a_patreon → Object { id: "jb2a_patreon", title: "JB2A - Patreon Complete Collection"

veevelder commented 1 year ago

thanks, ill add it to the next release

veevelder commented 1 year ago

so I managed to update and add the patreon package, I also added a couple of new settings were you can set the default animations for the on deck and current turn (in case the naming scheme is different from the free one) let me know if this works for you and sorry about the delay

veevelder commented 1 year ago

closing due to inactivity