veevelder / quick-combat

FoundryVTT module for small Combat Enhancements
MIT License
6 stars 5 forks source link

[FEATURE] Add the option when rolling the initiative to have Grouped initiative #35

Closed davelacorneille closed 1 year ago

davelacorneille commented 1 year ago

First, thank you for this module. I really like the macro to add combattant, start combat, next turn and ending combat.

Description of the feature: When adding multiple NPC of the same type, have the option that they have the same initiative (like the module Group Initiative)

Describe the solution you'd like Add the option when using the macro

Describe alternatives you've considered Add compatibility with the module Group Initiative

Additional context With Foundry 11.305, dnd5e 2.2.2, and Quick Combat 0.5.1: not compatible with Group Initiative 2.1.5

Also when adding more NPC of the same type, it should be the same initiative also.

veevelder commented 1 year ago

just wanted to update that I am working on this, i've just been busy lately

veevelder commented 1 year ago

to clarify you want to group the by the actor type and not names?

i.e. if there are 5 commoners in combat but they all have different token names you want them grouped as commoners

davelacorneille commented 1 year ago

Yes as actors type, as the advice in official 5e rules.

So the five commoners will have the same initiative.

On Wed, Aug 9, 2023, 14:59 Matt @.***> wrote:

to clarify you want to group the by the actor type and not names?

i.e. if there are 5 commoners in combat but they all have different token names you want them grouped as commoners

— Reply to this email directly, view it on GitHub https://github.com/veevelder/quick-combat/issues/35#issuecomment-1671973995, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXUDRP7H5V6LDRVDQQE4UMDXUPMX3ANCNFSM6AAAAAA2MLFVHM . You are receiving this because you authored the thread.Message ID: @.***>

davelacorneille commented 1 year ago

To be more specific, I don't think they should be grouped, just to have the same initiative! :)

On Wed, Aug 9, 2023 at 3:04 PM David Cournoyer @.***> wrote:

Yes as actors type, as the advice in official 5e rules.

So the five commoners will have the same initiative.

On Wed, Aug 9, 2023, 14:59 Matt @.***> wrote:

to clarify you want to group the by the actor type and not names?

i.e. if there are 5 commoners in combat but they all have different token names you want them grouped as commoners

— Reply to this email directly, view it on GitHub https://github.com/veevelder/quick-combat/issues/35#issuecomment-1671973995, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXUDRP7H5V6LDRVDQQE4UMDXUPMX3ANCNFSM6AAAAAA2MLFVHM . You are receiving this because you authored the thread.Message ID: @.***>

veevelder commented 1 year ago

Just another point of clarification, which option would you prefer?

  1. Global Setting
    • If enabled all NPCs will be grouped together for every combat regardless of how it was started, macro, hot key, etc
  2. Macro Option
    • Have 2 macros one for non-grouping npc combat and one for grouped npcs combat
davelacorneille commented 1 year ago

Global setting for me!

On Wed, Aug 9, 2023, 19:13 Matt @.***> wrote:

Just another point of clarification, which option would you prefer?

  1. Global Setting

    • If enabled all NPCs will be grouped together for every combat regardless of how it was started, macro, hot key, etc
  2. Macro Option

    • Have 2 macros one for non-grouping npc combat and one for grouped npcs combat

— Reply to this email directly, view it on GitHub https://github.com/veevelder/quick-combat/issues/35#issuecomment-1672299407, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXUDRP45PKV577O4IN5DIJLXUQKP5ANCNFSM6AAAAAA2MLFVHM . You are receiving this because you authored the thread.Message ID: @.***>

veevelder commented 1 year ago

feature added https://github.com/veevelder/quick-combat/wiki/Group-NPC-initiatives

let me know if its working for you

davelacorneille commented 1 year ago

I think that is working for the grouped initiative but I'm not able to have the auto initiative working anymore.

Do you think it is related to your last change?

veevelder commented 1 year ago

if you are noticing that when adding players/npcs to the combat tracker it no longer rolls initiative, thats on purpose in order to make the grouping work, initiative now rolls when starting combat. The exception is if you already have a combat started and you are adding tokens after, then their initiatives are rolled on add.

davelacorneille commented 1 year ago

Wow everything is perfect thank you so much :)

On Thu, Aug 10, 2023 at 8:28 AM Matt @.***> wrote:

if you are noticing that when adding players/npcs to the combat tracker it no longer rolls initiative, thats on purpose in order to make the grouping work, initiative now rolls when starting combat. The exception is if you already have a combat started and you are adding tokens after, then their initiatives are rolled on add.

— Reply to this email directly, view it on GitHub https://github.com/veevelder/quick-combat/issues/35#issuecomment-1673126057, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXUDRPYTIAEZCQQZPCZF7BTXUTHX7ANCNFSM6AAAAAA2MLFVHM . You are receiving this because you authored the thread.Message ID: @.***>