search

veg / hivtrace-viz

https://hivtrace-viz.vercel.app
7 stars 9 forks source link

Added devcontainer.json and fixed Dockerfile #119

Closed niemasd closed 11 months ago

niemasd commented 11 months ago

With this devcontainer file, VS Code (and GitHub Codespaces) will be able to create the development environment automatically. I also fixed the yarn installation in the Dockerfile.

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hivtrace-viz ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 1:21am
niemasd commented 11 months ago

Actually, there are some more fixes that need to be made to the Dockerfile, so don't merge this specific PR yet. The tn93 and hivtrace ones should be good to go, though

niemasd commented 11 months ago

I've ported the Dockerfile to use Oracle Linux instead of Ubuntu, and I'm now stuck at the same place as I was in Ubuntu:

https://github.com/veg/hivtrace-viz/issues/118#issuecomment-1808753760

@stevenweaver Thoughts?

stevenweaver commented 11 months ago

I've updated the supported engines to 18 and 19 until underlying dependencies can be updated to support Node 20 and above in earnest.

niemasd commented 11 months ago

@stevenweaver Great, thanks for the info! Switching to Node 18 worked perfectly. As of the following commit:

https://github.com/veg/hivtrace-viz/pull/119/commits/65db7052fc55871fd748e6bab42919ad2d35702d

I'm able to build directly from the development environment with the following:

yarn
yarn develop # or yarn build

So this one should be good to go now! In GitHub Codespaces, I'm even able to load the deployed web app

stevenweaver commented 11 months ago

Many thanks @niemasd.