search

veg / hyphy

HyPhy: Hypothesis testing using Phylogenies
http://www.hyphy.org
Other
201 stars 68 forks source link

Datamonkey: FEL figure1 = RuntimeError: Cannot read properties of undefined (reading '0') #1583

Closed eibnerg closed 1 year ago

eibnerg commented 1 year ago

Hi HyPhy/DM Team,

I'm receiving this error: "figure1 = RuntimeError: Cannot read properties of undefined (reading '0')" on any of the available FEL Plot types. The plot does not generate and it just shows the error message. This happens with various input files which don't cause problems with any other methods.

Regardless, thank you very much for providing such excellent tools for research!

Best, Georg

spond commented 1 year ago

Dear @eibnerg,

Can you please share the URL for the result page where you see this error?

Best, Sergei

eibnerg commented 1 year ago

@spond thanks for the quick reply, here are the results: https://www.datamonkey.org/fel/641b5cde56793b5e1e6168e7 subsets of this dataset yield the same error, e.g. https://www.datamonkey.org/fel/641bf91656793b5e1e6185c4

spond commented 1 year ago

Dear @eibnerg,

I'll tag @stevenweaver who does most DM development. I am not sure what the issue is on Datamonkey. You can download the JSON results by appending /results to the Datamonkey URL and feed them into the FEL visualization notebooks on Observable (which is where DM pulls the code from). Both of your results files display just fine there, so something must be happening because of notebook embedding.

https://observablehq.com/@spond/fel?url=https://www.datamonkey.org/fel/641b5cde56793b5e1e6168e7/results

https://observablehq.com/@spond/fel?url=https://www.datamonkey.org/fel/641bf91656793b5e1e6185c4/results

Best, Sergei

stevenweaver commented 1 year ago

Dear @spond,

I'm using https://observablehq.com/@hyphy_software/fel-analysis-result-visualization?url=https://www.datamonkey.org/fel/641b5cde56793b5e1e6168e7/results for Datamonkey.

I can update the notebook. I'm not dynamically including the notebooks because 1) Observable may change their API at any time and 2) for freedom to update notebooks without fear of repercussion on the production site.

Best, Steven

stevenweaver commented 1 year ago

Fix has been deployed.

eibnerg commented 1 year ago

Amazing! Let me know next time you're in Berlin so I can buy you a beer =)