search

veg / hyphy

HyPhy: Hypothesis testing using Phylogenies
http://www.hyphy.org
Other
200 stars 68 forks source link

increased max number of GA rate classes from 5 to 18 #1649

Closed hverdonk closed 8 months ago

stevenweaver commented 8 months ago

@hverdonk -- Would it be possible to provide reasoning to increase the max number?

hverdonk commented 8 months ago

I upped it locally to test the GA's stability with larger numbers of rate classes, and opened a pull request in case someone wanted to replicate my work whenever it gets published.

That said, I only tested up to 6 rate classes, and I don't think anyone would ever go beyond that in real life, so feel free to close this pull request without merging.

stevenweaver commented 8 months ago

OK, I increased it to 6 to match the maximum performed.

hverdonk commented 8 months ago

Perfect, thank you!