Bug in escaping single quotes in Newick export

veg / phylotree.js

Interactive viewer of phylogenetic trees

http://phylotree.hyphy.org

MIT License

169 stars 71 forks source link

Bug in escaping single quotes in Newick export #448

Closed gaurav closed 5 months ago

gaurav commented 7 months ago

I made a dumb mistake in my previous PR (#441) where I used replace() instead of replaceAll(), so that only the first single quote was being escaped.

This PR fixes that, as well as making a few other minor fixes:

Added a test to catch this bug.
Replaced one use of != with !==.
Cleaned up the code, possibly fixing some other bugs as well.

Closes https://github.com/veg/phylotree.js/issues/450.

stevenweaver commented 5 months ago

Released in 2.0.1.