Bug in escaping single quotes in Newick export

veg / phylotree.js

Interactive viewer of phylogenetic trees

http://phylotree.hyphy.org

MIT License

169 stars 71 forks source link

Bug in escaping single quotes in Newick export #450

Closed gaurav closed 5 months ago

gaurav commented 6 months ago

I made a dumb mistake in my previous PR (#441) where I used replace() instead of replaceAll(), so that only the first single quote was being escaped. I've fixed this bug and added a test for it in PR #448. This bug just tracks that issue.

gaurav commented 5 months ago

Just wanted to remind y'all to check PR #448 and see if it fixes this bug! If you'd like me to make any changes to that PR, please let me know!