Closed NickCrews closed 1 year ago
Thanks for going through this thoroughly @NickCrews! I think facet, trells, and "small multiple" all align with the definition you have in a
, while "repeated" aligns with the definition you have in b
. It is great that the main documentation definitions are correct and it would be helpful with consistency throughout as you suggest. I think "trellis" is still a common term, so maybe we could mention it as a synonym where we define "facet" and then sync all the examples to only use facet? I'm happy to review a PR.
I agree with mentioning trellis in the definition of facet, but then avoiding it everywhere else.
That sounds like a good plan of action.
I notice that the examples and docs seem to use "trellis", "facet", and "repeated" inconsistently. Possible meanings:
a. "multiple subplots, each one showing a subset of the data" b. "mutiple subplots, each one showing a different variable" c. something else
The docs define these as
But the examples are inconsistent:
I propose making these examples consistent with their definitions: a. Remove all uses of trellis, replacing with facet b. Use the term iff that is what the chart is doing
grepping through the codebase shows that the term "trellis" only appears in these examples, and in the vega-lite schema. So we could also file upstream to scrub "trellis" from there, but that might not be needed.
I can write a PR if this is a good idea. This would also be a great first PR for someone else.