search

vega / altair

Declarative statistical visualization library for Python
https://altair-viz.github.io/
BSD 3-Clause "New" or "Revised" License
9.39k stars 795 forks source link

ci: Drop support for Python `3.8` #3647

Closed dangotbanned closed 1 month ago

dangotbanned commented 1 month ago

Closes #3497

Note for reviewers

Most of the changes in this PR were handled by ruff, and relate to these 3.9 changes:

Essentially, this looks like a big job but excluding (https://github.com/vega/altair/pull/3647/commits/c7658977e44a26972809961b0f9360064013391b) this is actually quite a minor PR

Tasks

dangotbanned commented 1 month ago

The CI error is a bit cryptic, but I think #3494 was due to similar error

@MarcoGorelli if you're available, I just wanted to run this by you in case you can spot the issue in

https://github.com/vega/altair/actions/runs/11438192791/job/31819284620?pr=3647

I think it is this line, but quite unsure why this has become an issue here

https://github.com/vega/altair/blob/61f1db7b7a9c06596823b2da66ad189db0804269/tests/vegalite/v5/test_api.py#L34

Update

Fixed in test: Try invoking ibis.set_backend only in scopes that use it

dangotbanned commented 1 month ago

Not sure how to unblock the expected checks for:

They were removed in da300c3 (#3647)

dangotbanned commented 1 month ago

https://github.com/vega/altair/pull/3647#issuecomment-2426481888 It seems this was baked into the branch protection rules in https://github.com/vega/altair/pull/3562#issuecomment-2322886076

Screenshot from that PR (@binste)

image

I still don't have the permissions for viewing/editing these rules - so I'll need some help updating them if anyone is available?

@mattijn @jonmmease @joelostblom

mattijn commented 1 month ago

I've removed the rules in the rule set for Python version 3.8. All checks are now green, is that in line what is expected? I did not look careful if the CI in this PR was still red before I made the change to the ruleset.

dangotbanned commented 1 month ago

I've removed the rules in the rule set for Python version 3.8. All checks are now green, is that in line what is expected? I did not look careful if the CI in this PR was still red before I made the change to the ruleset.

Thanks @mattijn

It was all green except, with the two 3.8 jobs mentioned in https://github.com/vega/altair/pull/3647#issuecomment-2426481888 marked as expected (but neither pass/failing) No reds since 5995202 (#3647)

mattijn commented 1 month ago

Is pandas version 1.1.3 the minimum supported version for Python 3.9?

dangotbanned commented 1 month ago

Is pandas version 1.1.3 the minimum supported version for Python 3.9?

That was the earliest I found going through the release notes @mattijn

I think numpy had some level of support before 1.19.3, but it looked like more of an announcement in that version

mattijn commented 1 month ago

Thanks! Moving forward🥳