Convert SpecQueryModelGroup to Class

vega / compassql

CompassQL Query Language for visualization recommendation.

Other

273 stars 43 forks source link

Closed kanitw closed 8 years ago

kanitw commented 8 years ago

So that people won't modify it's inner context randomly. Plus, getTopItem can be a class method.

kanitw commented 8 years ago

[x] we can also get rid of isSpecQueryModelGroup as we can reliably use instanceof

kanitw commented 8 years ago

[x] move it to model.ts so we get cql.model.SpecQueryModelGroup next to cql.model.SpecQueryModel in the namespace.

kanitw commented 8 years ago

[x] rename getTopItem to getTopSpecModel, so it's clearer :)
[x] find all occurrence of isSpecQueryModelGroup and getTopSpecModel in
- [x] vg-editor,
- [x] vega-lite-ui and
- [x] voyager2 and replace them