search

vega / falcon

Brushing and linking for big data
https://vega.github.io/falcon/flights
Other
942 stars 52 forks source link

Support theming #144

Open domoritz opened 5 years ago

domoritz commented 5 years ago

Add support for theming with Vega configs (https://vega.github.io/vega/docs/config/).

josesaranda commented 5 years ago

I think this support require a lot of effort. You can accept the PR for a minor version.

domoritz commented 5 years ago

I've actually manually set the config before to create a dark mode. It's actually pretty nice.

image

You can find my code at https://github.com/uwdata/falcon/commit/8a9de43496842e62d883dc1e16b581e22ddfe678. However, I didn't extract the Vega config into the Falcon config, which I now realize is the right approach.

josesaranda commented 5 years ago

If you want to add more theming support you can do that, but i only need to change the bar colors at the moment. Please approve it

domoritz commented 5 years ago

Unfortunately, this change only would introduce backward-incompatible changes once we add support for theming. I don't plan to accept it into the main repo but you can use your fork until theming support lands here.