search

vega / ipyvega

IPython/Jupyter notebook module for Vega and Vega-Lite
BSD 3-Clause "New" or "Revised" License
372 stars 65 forks source link

Make the conda package noarch #358

Open martinRenou opened 3 years ago

martinRenou commented 3 years ago

cc. @wolfv

It looks like this package is not noarch on conda-forge, while it could be.

It cannot be noarch yet because of the post-link file that install the nbextension manually. In order to remove this post-link, I suspect you would need to install your vega.json file under the etc/jupyter/nbconfig/notebook.d directory for Jupyter to discover.

For interactive widgets, we usually use data_files for installing this kind of files, see this for example.

Unfortunately, the build tool you are using (poetry) does not support data_files, see this issue, and they don't seem eager to support this feature.

domoritz commented 3 years ago

Thanks for filing the issue. If you have a suggestion for improving things, I would love a pull request.

martinRenou commented 3 years ago

I am honestly not sure what the best approach would be, whether this could actually be achieved with poetry or if you would need to choose another build tool.

domoritz commented 3 years ago

I'm open to other build tools as long as they are easy for me to use. I'd prefer if poetry could add support.