Closed kanitw closed 9 years ago
I think we should have a better name.
We can replace one more time too. Right now we should do this refactor asap because otherwise the gulp gen
task doesn't work correctly
I like that you fixed the tests so feel free to merge. We can rename later.
Can't merge.
No doubt. We have merged many other prs after i created this pr. Will fix and let you know.
— Kanit "Ham" Wongsuphasawat http://kanitw.yellowpigz.com/
Painfully tapped iPhone keyboard--only for you. Sorry for brevity and typos.
On Tue, Feb 24, 2015 at 1:09 PM, Dominik Moritz notifications@github.com wrote:
Can't merge.
Reply to this email directly or view it on GitHub: https://github.com/uwdata/vegalite-ui/pull/170#issuecomment-75846536
tests are fixed in #186
fixes #110 change
vleApp
tovegalite-ui
Please merge #169 first!