vega / polestar

Lightweight Tableau-style interface for visual analysis, built on Vega-lite.
http://vega.github.io/polestar
Other
367 stars 47 forks source link

change `vleApp` to `vegalite-ui` #170

Closed kanitw closed 9 years ago

kanitw commented 9 years ago

fixes #110 change vleApp to vegalite-ui

Please merge #169 first!

domoritz commented 9 years ago

I think we should have a better name.

kanitw commented 9 years ago

We can replace one more time too. Right now we should do this refactor asap because otherwise the gulp gen task doesn't work correctly

domoritz commented 9 years ago

I like that you fixed the tests so feel free to merge. We can rename later.

domoritz commented 9 years ago

Can't merge.

kanitw commented 9 years ago

No doubt.  We have merged many other prs after i created this pr.  Will fix and let you know.

— Kanit "Ham" Wongsuphasawat http://kanitw.yellowpigz.com/ 

Painfully tapped iPhone keyboard--only for you. Sorry for brevity and typos.

On Tue, Feb 24, 2015 at 1:09 PM, Dominik Moritz notifications@github.com wrote:

Can't merge.

Reply to this email directly or view it on GitHub: https://github.com/uwdata/vegalite-ui/pull/170#issuecomment-75846536

kanitw commented 9 years ago

tests are fixed in #186