use deepCopy to fix #214

vega / polestar

Lightweight Tableau-style interface for visual analysis, built on Vega-lite.

http://vega.github.io/polestar

Other

367 stars 47 forks source link

Closed kanitw closed 9 years ago

kanitw commented 9 years ago

rename package, use deepCopy to fix #214
prevent dragging COUNT to row/col (and show alert if they do) — ideally this shouldn’t show drop target if a count field is dragged but I fail to do that for now.

kanitw commented 9 years ago

@domoritz could you test this.. I know this is a risky fix. But if I don’t fix, this can screw up the whole study anyway.

domoritz commented 9 years ago

[ ] If I change the type from number to text, the caret disappears. That should not happen.
[ ] Don't show caret for x, y, col, row if there is no field dropped

Other than that, it seems to work fine.

kanitw commented 9 years ago

Don't show caret for x, y, col, row if there is no field dropped

you mean the shelf caret, not the field caret? If that's the case, maybe it makes sense to do #216?

kanitw commented 9 years ago

If I change the type from number to text, the caret disappears. That should not happen.

This requires knowledge of original type.. I think it’s okay to always show caret for text for now then. (I will still hide it for COUNT.