fixes #242, fixes #285 -- refactor vlPlot, spec, vl/vgSpecEditor

vega / polestar

Lightweight Tableau-style interface for visual analysis, built on Vega-lite.

http://vega.github.io/polestar

Other

367 stars 47 forks source link

fixes #242, fixes #285 -- refactor vlPlot, spec, vl/vgSpecEditor #296

Closed kanitw closed 9 years ago

kanitw commented 9 years ago

merge https://github.com/uwdata/vega-lite-ui/pull/15 and publish vega-lite-ui first

domoritz commented 9 years ago

How does this fix #285?

kanitw commented 9 years ago

the redundant part is that vgSpec was originally compiled twice both in Spec.service.js and vlPlot.

Now it is only compiled once. Basically, vlPlot updates Spec.chart.vgSpec when it renders. Meanwhile, vgSpecEditor and vlSpecEditor can still read from Spec.chart.

In the future, we might consider moving vl/vgSpecEditor to vlui and have them take chart as input. But I think that's lower priority for now.