Fix test, migrate to mocha, enable travis

vega / polestar

Lightweight Tableau-style interface for visual analysis, built on Vega-lite.

http://vega.github.io/polestar

Other

367 stars 47 forks source link

Fix test, migrate to mocha, enable travis #297

Closed kanitw closed 9 years ago

kanitw commented 9 years ago

please merge #296, https://github.com/uwdata/vega-lite-ui/pull/15 and publish vega-lite-ui@0.7.8 first

fixes #271
also fixes https://github.com/uwdata/vega-lite-ui/issues/14

kanitw commented 9 years ago

@domoritz I just merged your change in master into this branch.

domoritz commented 9 years ago

I get a bunch of errors when I start the app. Does everything work for you? Can you reinstall all the bower and npm dependencies to see whether things are breaking?

kanitw commented 9 years ago

It’s just outdated vlui version. It should work now. Let me know if it’s still broken.

domoritz commented 9 years ago

I can't test right now because the wifi doesn't allow git. I'll merge when I get back or you can test and merge. The code looks fine.

domoritz commented 9 years ago

There is a bug with the nominal stuff. If you change to "text-ordinal" and then change the aggregation, it selects number.

domoritz commented 9 years ago

Which also happens in master.

kanitw commented 9 years ago

Can u create an issue?

— Kanit "Ham" Wongsuphasawat http://kanitw.yellowpigz.com/

Painfully tapped iPhone keyboard--only for you. Sorry for brevity and typos.

On Thu, Jun 4, 2015 at 7:11 PM, Dominik Moritz notifications@github.com wrote:

Merged #297.

Reply to this email directly or view it on GitHub: https://github.com/uwdata/polestar/pull/297#event-323142945

domoritz commented 9 years ago

See #299