search

vega / polestar

Lightweight Tableau-style interface for visual analysis, built on Vega-lite.
http://vega.github.io/polestar
Other
367 stars 47 forks source link

Zq/markicons #361

Closed light-and-salt closed 8 years ago

light-and-salt commented 8 years ago

Added icons to marktype select using Drop.js. screen shot 2016-01-20 at 2 27 17 pm

HTML <select> doesn't support icons in its options so I used <div> tag with ng-repeat to render the marktype options.

Initially the ng-repeat options were not showing up in the pop up menu. I wrapped new Drop() inside $timeout to fix this problem. See this question for details.

These are the icons used: point point-2 tick tick-5 I'm not sure what's the difference between tick and point. Is tick "-" a shaped point? bar screen shot 2016-01-20 at 2 40 37 pm line screen shot 2016-01-20 at 2 41 46 pm area screen shot 2016-01-20 at 2 41 38 pm text screen shot 2016-01-20 at 2 41 52 pm

Icons for point and tick are custom-made because I couldn't find suitable ones on fontawesome. I put the icon files under "assets/fonts/"

kanitw commented 8 years ago

there are some conflict .. so we can't merge.

light-and-salt commented 8 years ago

@kanitw @domoritz The merge conflicts are in shelves.html and shelves.js, basically the marktype-related lines that I changed. This is because I didn't checkout my zq/markicons branch from the head of the master branch, which I should. However I cannot run the latest version of Pole* on the master branch -- the data and the shelves are not showing up (please see screenshot below):

screen shot 2016-01-25 at 2 18 27 pm

In my Mac terminal, I see a lot of test cases failed after npm start (please see the log file below): log.txt

And some errors in my Chrome console: screen shot 2016-01-25 at 2 32 28 pm

Could you help me figure out why this is happening? After that I can branch from the head of master, make the icon changes and send a new pull request. Thanks!

kanitw commented 8 years ago

FYI, this Pr might still be useful, but we have to re-do it for vega-lite-ui instead.