Closed dsmedia closed 3 months ago
Rather than validating, should the script just generate the file? We can always check that the diff is empty in git. It would be more similar to the other scripts.
We could also run the script as part of the workflows if we want to have tests.
What changed about the dataset? I'm asking since it affects what version bump this implies.
What changed about the dataset? I'm asking since it affects what version bump this implies.
The original and script-generated budget.json files are identical in content, but differ in formatting: the original file has no space after the colons separating keys and values, while the script in my prior commit generated a json with a space after each colon. In this new commit, I've updated the script to generate a JSON formatted like the original.
budget.json
had no spaces after colons separating keys and values.budget.py
to generate JSON using default formatting of including spaces after colons.budget.json
(identical content, different formatting).budget.py
to generate JSON without spaces after colons (matching original format).budget.json
to match the original formatting.Having a space after the :
is actually nice and a good practice. We can change the format without bumping the minor version. It's nice to see that the diff is empty after the format change. Let's undo 6615d79 and merge. Thank you!
Thank you
Partially addresses #15
Changes made:
validate_budget_data.py
in the scripts directory to validate the budget data against the original source