vega / vega-lite

A concise grammar of interactive graphics, built on Vega.
https://vega.github.io/vega-lite/
BSD 3-Clause "New" or "Revised" License
4.67k stars 608 forks source link

Composition Docs Revision #1245

Closed kanitw closed 6 years ago

kanitw commented 8 years ago
kanitw commented 7 years ago

composition.md

Vega-Lite automatically unions scale domains and combines axes and legends. However, Vega-Lite can not enforce that a unioned domain is semantically meaningful. To prohibit layering of composite views with incompatible layouts, the layer operator restricts its operands to be single or layered views.

I think these information are too detailed for a composition intro page.

mcorrell commented 7 years ago
kanitw commented 7 years ago

facet.md

A FacetFieldDef is similar to a channel definition.

light-and-salt commented 7 years ago

Through this hierarchical composition, you can create a whole dashboard as a single specification.

This is so exciting! It would be nice if there is an example specification for a whole dashboard.

The word "dashboard" makes me think of layout, which Tableau and PowerBI supports. Those kind of dashboards typically have views organized in various ways (e.g., small and large views on the same page, repeated views, concatenated views and layered views on the same dashboard etc.). I can kind of foresee how it can be achieved by "hierarchical composition". Just wondering if that's the kind of dashboard you mean here...

jhoffswell commented 7 years ago

On the resolve page, you say:

The defaults documented on the faceting, layering, concatenation, and repeating pages.

However, the documentation for resolve on these pages seems to generally be about one sentence, e.g.

The default resolutions for facet are shared scales, axes, and legends.

If the default documentation is going to be this short on the other pages, I think it might be more reasonable to just include the same level of documentation on this page as well, rather than requiring the user to check each other page individually. Maybe something like:

The default resolutions for facet and layer are shared scales, axes, and legends. The default resolutions for concatenation are independent scales, axes, and legends. The default resolutions for repeat are independent scales and axes for spatial channels and shared scales and legends for legends.

jhoffswell commented 7 years ago

On the repeat page, you say:

To create a faceted view, define how the data should be faceted in facet and how each facet should be displayed in the spec.

This sentence probably needs to be changed (or removed) for this page.

jhoffswell commented 7 years ago

On the composition page, it might be nice to have small examples/images to help explain what each operator is for to help readers find the correct part of the documentation for their task.

jhoffswell commented 7 years ago

On the layer page, you say:

This operator is none of Vega-Lite’s view compositon operators.

Which has two typos, fixed below:

This operator is one of Vega-Lite’s view composition operators.

jhoffswell commented 7 years ago

On the layer page, when you say:

The population of the German city of Falkensee over time. Based on a visualization built using Vega.

The link does not work.

kanitw commented 7 years ago
domoritz commented 7 years ago

Fixed broken link to fsee example in c04f86d0. Thanks @jhoffswell!

domoritz commented 7 years ago

Fixed typos in 87340ccf

kanitw commented 7 years ago
kanitw commented 7 years ago
kanitw commented 7 years ago