search

vega / vega-lite

A concise grammar of interactive graphics, built on Vega.
https://vega.github.io/vega-lite/
BSD 3-Clause "New" or "Revised" License
4.65k stars 603 forks source link

Optimize time units and aggregates #4181

Open domoritz opened 6 years ago

domoritz commented 6 years ago

For example in repeat_layer.

image

domoritz commented 6 years ago

@invokesus is this something you want to tackle?

Saba9 commented 5 years ago

Unless I'm mistaken the issue with duplicate TimeUnits is currently addressed here: https://github.com/vega/vega-lite/blob/5a19e609ffb1901887c46e12a20cf87953b81dc7/src/compile/data/optimize.ts#L71 What optimization could be made with the AggregateNodes in this example?

domoritz commented 5 years ago

As discussed in the meeting, aggregates would be covered by https://github.com/vega/vega-lite/pull/4269