search

vega / vega-themes

Themes for stylized Vega and Vega-Lite visualizations.
https://vega.github.io/vega-themes
BSD 3-Clause "New" or "Revised" License
128 stars 30 forks source link

Carbon theme #478

Closed johnhaldeman closed 1 year ago

johnhaldeman commented 1 year ago

I've been playing around with making Vega charts follow IBM's Carbon guidelines: https://carbondesignsystem.com/data-visualization/simple-charts/

Very simple proof of concept here: https://observablehq.com/d/20ea4bb8bdd0e49a

I was wondering if I was to build a formal theme and PR it if it might be merged into this project - Are new themes being accepted?

johnhaldeman commented 1 year ago

Oh, I forgot to mention. Looking at the already built themes, I'd endeavor to contain all theming inside a configuration object - not scattered all about like it is in the PoC notebook.

domoritz commented 1 year ago

Yes, we do accept new themes as long as there is no licensing issue.

johnhaldeman commented 1 year ago

Great! Thank you! I'll work something up.

Carbon is licensed under Apache 2.0: https://github.com/carbon-design-system/carbon/blob/main/LICENSE