search

vega / vega-themes

Themes for stylized Vega and Vega-Lite visualizations.
https://vega.github.io/vega-themes
BSD 3-Clause "New" or "Revised" License
128 stars 30 forks source link

feat: add carbon themes #479

Closed johnhaldeman closed 1 year ago

johnhaldeman commented 1 year ago

Hello! Thank you for the time in reviewing the PR. I'm happy to make any changes you'd like, just excited to contribute in a small way. I'm a big fan of vega. PR is for this issue: https://github.com/vega/vega-themes/issues/478

Changes:

1) Update the links in readme to point to main branch instead of old master branch (Power BI link for example was broken).

2) Add a new chart to the Vega Theme Test page to help test diverging color scales. The chart spec taken from this vega lite example: https://vega.github.io/vega-lite/examples/joinaggregate_residual_graph.html image

3) Add themes based on the IBM Carbon charts specification. One theme for each of Carbon white, g10, g90 and g100. The two two lighter themes and two darker themes appear to be the same except for a background color specification. https://carbondesignsystem.com/data-visualization/getting-started/ image

Thanks again!

domoritz commented 1 year ago

Thank you!

domoritz commented 1 year ago

I made a new release and updated the demo. Looks great.

johnhaldeman commented 1 year ago

Thank so much!