vega / vegafusion

Serverside scaling for Vega and Altair visualizations
https://vegafusion.io
BSD 3-Clause "New" or "Revised" License
303 stars 15 forks source link

pre-transform spec patching should fail when dataset is added #405

Closed jonmmease closed 8 months ago

jonmmease commented 8 months ago

Spec patching inputs three specs:

When the deltas between spec1 and spec2 are compatible with pre_transformed_spec1, then pre_transformed_spec2 is returned. But when the delta is not compatible, None should be returned.

When spec2 adds a new dataset that's not present in spec1, we currently add the new dataset to pre_transformed_spec2. But this is incorrect since the new dataset will not be pre-transformed. When a new dataset it added, patching should fail and return None.