vega / vl-convert

Utilities for converting Vega-Lite specs from the command line and Python
BSD 3-Clause "New" or "Revised" License
84 stars 9 forks source link

Fix linux aarch64 build of CLI #155

Open jonmmease opened 4 months ago

jonmmease commented 4 months ago

After deno update, the aarch64 linux build started failing.

See https://github.com/vega/vl-convert/actions/runs/8070547335/job/22048139080

   Compiling is-macro v0.3.0
error[E0446]: private type `DynFutureInfoErased<T, C>` in public interface
  --> /workspace/cargo-arm64/registry/src/index.crates.io-6f17d22bba15001f/deno_core-0.264.0/runtime/op_driver/future_arena.rs:78:9
   |
26 | struct DynFutureInfoErased<T, C> {
   | -------------------------------- `DynFutureInfoErased<T, C>` declared as private
...
78 |   Arena(ArenaBox<DynFutureInfoErased<T, C>>),
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak private type

error[E0446]: private type `DynFutureInfo<T, C, M, F>` in public interface
   --> /workspace/cargo-arm64/registry/src/index.crates.io-6f17d22bba15001f/deno_core-0.264.0/runtime/op_driver/future_arena.rs:180:3
    |
36  | / struct DynFutureInfo<
37  | |   T: 'static,
38  | |   C: 'static,
39  | |   M: FutureContextMapper<T, C, F::Output>,
40  | |   F: Future,
41  | | > {
    | |_- `DynFutureInfo<T, C, M, F>` declared as private
...
180 | /   pub fn allocate<F, R, M: FutureContextMapper<T, C, R> + 'static>(
181 | |     &self,
182 | |     context: M,
183 | |     future: F,
...   |
186 | |     F: Future<Output = R> + 'static,
187 | |     DynFutureInfo<T, C, M, F>: ContextFuture<T, C>,
    | |___________________________________________________^ can't leak private type

error[E0446]: crate-private type `V8StartupData` in public interface
   --> /workspace/cargo-arm64/registry/src/index.crates.io-6f17d22bba15001f/deno_core-0.264.0/runtime/setup.rs:110:1
    |
110 | / pub fn create_isolate(
111 | |   will_snapshot: bool,
112 | |   maybe_create_params: Option<v8::CreateParams>,
113 | |   maybe_startup_snapshot: Option<V8StartupData>,
114 | |   external_refs: &'static v8::ExternalReferences,
115 | | ) -> v8::OwnedIsolate {
    | |_____________________^ can't leak crate-private type
    |
   ::: /workspace/cargo-arm64/registry/src/index.crates.io-6f17d22bba15001f/deno_core-0.264.0/runtime/snapshot.rs:37:1
    |
37  |   pub(crate) enum V8StartupData {
    |   ----------------------------- `V8StartupData` declared as crate-private

The python wheel compiles fine though.