search

vega / vl-convert

Utilities for converting Vega-Lite specs from the command line and Python
BSD 3-Clause "New" or "Revised" License
96 stars 12 forks source link

Update Deno, build aarch64 wheels with QEMU #68

Closed jonmmease closed 1 year ago

jonmmease commented 1 year ago

Fixes https://github.com/vega/vl-convert/issues/67 by building the aarch64 wheels with QEMU. This also unblocks the ability to update Deno.

I ran into some issues with cross-compiling the CLI executables on osx-arm64 and linux-aarch64, so I went ahead and removed these for now.

jonmmease commented 1 year ago

Notes: I tried bumping the manylinux version to 2.24 and 2.28 but crash persists

jonmmease commented 1 year ago

Building with the standard manylinux docker container with QEMU in 66d5d73 produced a working aarch64 wheel 🎉 .

It took 2.5 hours to build a single wheel though. Also, the wheel built with x86_64 in the name for some reason, so I had to rename the wheel file before testing.

jonmmease commented 1 year ago

Compiling with QEMU is a bit slow (2.5 hours to build the wheel), but we only need to run this on releases, so I think it's acceptable going forward. It also unblocked the ability to update Deno, which is a big benefit itself.