search

vega / vl-convert

Utilities for converting Vega-Lite specs from the command line and Python
BSD 3-Clause "New" or "Revised" License
100 stars 12 forks source link

Add option to control whether to display Vega-Lite compiler warnings #96

Closed jonmmease closed 1 year ago

jonmmease commented 1 year ago

Adds a show_warnings option to the Rust, Python, and CLI interfaces to control whether Vega-Lite compiler warnings should be printed.

Previously, these were always printed. Now they are not printed by default and can be enabled using the show_warnings argument.

See https://github.com/altair-viz/altair/issues/3138 for some discussion of hiding these warnings

cc @joelostblom

joelostblom commented 1 year ago

Great, thanks for making the default consistent with how altair works by default! I think that will be helpful for using vegafusion as a drop-in replacement for the default renderer, and we can still discuss changing the default behavior of both in the future if there is a way to show warnings in altair (and if we think these are actually helpful).

joelostblom commented 1 year ago

@jonmmease Just wanted to check in if it would be possible to cut a point release that includes this fix? It would be helpful for a class I start teaching middle of next week, but it is not critical in any way; I just thought I would check in what your plans were for the next release.

jonmmease commented 1 year ago

Yeah, sounds good. I'm hoping Vega will be released soon so that VlConvert can pick up the fix for https://github.com/vega/vl-convert/issues/30, but either way I can cut a release over the weekend.

joelostblom commented 1 year ago

Super, thank you!