search

vega / voyager-electron

Creative Commons Zero v1.0 Universal
4 stars 1 forks source link

8 use persistence api #9

Closed tafsiri closed 7 years ago

tafsiri commented 7 years ago

This adds 'take snapshot' and 'restore snapshot' buttons to test the persistence api and closes #8.

It also updates voyager electron to use the npm published library.

Note: this depends on https://github.com/vega/voyager/pull/390 and deploying a new version of the library to npm. It also depends on some package.json fixes to voyager that @vlandham is working on. So we should hold off on merging this for a bit.

ping @vlandham @kanitw

tafsiri commented 7 years ago

screen shot 2017-06-19 at 4 38 48 pm

tafsiri commented 7 years ago

This PR has been updated with your suggestions @kanitw, however restoring snapshots depends on https://github.com/vega/voyager/issues/398 being resolved.

tafsiri commented 7 years ago

@kanitw this is now ready for review. With an upgrade to a new version of voyager that fixes the state serialization, one can take and restore state snapsots.

tafsiri commented 7 years ago

ping @kanitw. requested changes have been made.