vega / voyager

Visualization Tool for Data Exploration
http://vega.github.io/voyager
Other
1.45k stars 179 forks source link

Q Filter: Plot Color Updates, but the Legend Doesn't #821

Open light-and-salt opened 6 years ago

light-and-salt commented 6 years ago

Filter Acceleration 8-25:

screen shot 2018-06-13 at 2 44 25 pm

Filter Acceleration 8-11:

screen shot 2018-06-13 at 2 45 27 pm

Looks like the color scales in the plots have indeed updated to 8-11, but the color legends are still 8-25.

I can see two options going forward:

(a) On the one hand, I think there are some benefits to hold the color scales constant (always set the color scale domain to the raw data domain). This way, when the user changes the Q filter, the mark colors will be consistent across time. The same marks will always have the same color. If we choose to go this way, we need to set the color scale domain in plots to always use raw data domain despite filters.

(b) On the other hand, each single plot will use color more effectively if we don't hold color scale domains constant. If we choose to go this way, we need to fix the color legend to correctly reflect the filtered scale domain.